An improper locking due to the unreleased lock before program exit

[ycaibb]

Hi developers, in the below codes, the lock threads_lock could be not released before program's exit fail(). I think it is better to write release_(&(threads_lock), file, line); before the abort(); for better resource management and code symmetry. Thanks!

pigz/yarn.c

Lines 307 to 329 in b6da942

	possess_(&(threads_lock), file, line);
	// create the thread and call ignition() from that thread
	thread *th = my_malloc(sizeof(struct thread_s), file, line);
	pthread_attr_t attr;
	int ret = pthread_attr_init(&attr);
	if (ret)
	fail(ret, file, line, "attr_init");
	ret = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE);
	if (ret)
	fail(ret, file, line, "attr_setdetachstate");
	ret = pthread_create(&(th->id), &attr, ignition, capsule);
	if (ret)
	fail(ret, file, line, "create");
	ret = pthread_attr_destroy(&attr);
	if (ret)
	fail(ret, file, line, "attr_destroy");
	// put the thread in the threads list for join_all()
	th->done = 0;
	th->next = threads;
	threads = th;
	release_(&(threads_lock), file, line);

Best,

[ycaibb]

Hi, developers @madler

Any comments would be highly appreciated. Thank you.

Best Regards,

[madler]

There's no point in attempting to clean up, as the program immediately exits.