Skip to content

Commit

Permalink
configure: Pass LDFLAGS to link tests
Browse files Browse the repository at this point in the history
LDFLAGS can contain critical flags without which linking wont succeed
therefore ensure that all configure tests involving link time checks are
using LDFLAGS on compiler commandline along with CFLAGS to ensure the
tests perform correctly. Without this some tests may fail resulting in
wrong confgure result, ending in miscompiling the package

Signed-off-by: Khem Raj <raj.khem@gmail.com>
  • Loading branch information
kraj committed Oct 17, 2022
1 parent 04f42ce commit 555b469
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions configure
Expand Up @@ -436,7 +436,7 @@ if test $shared -eq 1; then
echo Checking for shared library support... | tee -a configure.log
# we must test in two steps (cc then ld), required at least on SunOS 4.x
if try $CC -w -c $SFLAGS $test.c &&
try $LDSHARED $SFLAGS -o $test$shared_ext $test.o; then
try $LDSHARED $SFLAGS $LDFLAGS -o $test$shared_ext $test.o; then
echo Building shared library $SHAREDLIBV with $CC. | tee -a configure.log
elif test -z "$old_cc" -a -z "$old_cflags"; then
echo No shared library support. | tee -a configure.log
Expand Down Expand Up @@ -498,7 +498,7 @@ int main(void) {
}
EOF
fi
if try $CC $CFLAGS -o $test $test.c; then
if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then
sizet=`./$test`
echo "Checking for a pointer-size integer type..." $sizet"." | tee -a configure.log
CFLAGS="${CFLAGS} -DNO_SIZE_T=${sizet}"
Expand Down Expand Up @@ -532,7 +532,7 @@ int main(void) {
return 0;
}
EOF
if try $CC $CFLAGS -o $test $test.c; then
if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then
echo "Checking for fseeko... Yes." | tee -a configure.log
else
CFLAGS="${CFLAGS} -DNO_FSEEKO"
Expand All @@ -549,7 +549,7 @@ cat > $test.c <<EOF
#include <errno.h>
int main() { return strlen(strerror(errno)); }
EOF
if try $CC $CFLAGS -o $test $test.c; then
if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then
echo "Checking for strerror... Yes." | tee -a configure.log
else
CFLAGS="${CFLAGS} -DNO_STRERROR"
Expand Down Expand Up @@ -656,7 +656,7 @@ int main()
return (mytest("Hello%d\n", 1));
}
EOF
if try $CC $CFLAGS -o $test $test.c; then
if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then
echo "Checking for vsnprintf() in stdio.h... Yes." | tee -a configure.log

echo >> configure.log
Expand Down Expand Up @@ -746,7 +746,7 @@ int main()
}
EOF

if try $CC $CFLAGS -o $test $test.c; then
if try $CC $CFLAGS $LDFLAGS -o $test $test.c; then
echo "Checking for snprintf() in stdio.h... Yes." | tee -a configure.log

echo >> configure.log
Expand Down

0 comments on commit 555b469

Please sign in to comment.