Skip to content

Commit

Permalink
Use memcpy for stored blocks.
Browse files Browse the repository at this point in the history
This speeds up level 0 by about a factor of three, as compared to
the previous byte-at-a-time loop. We can do much better though. A
later commit avoids this copy for level 0 with large buffers,
instead copying directly from the input to the output. This commit
still speeds up storing incompressible data found when compressing
normally.
  • Loading branch information
madler committed Dec 4, 2016
1 parent 03614c5 commit a456d89
Showing 1 changed file with 7 additions and 30 deletions.
37 changes: 7 additions & 30 deletions trees.c
Expand Up @@ -152,8 +152,6 @@ local int detect_data_type OF((deflate_state *s));
local unsigned bi_reverse OF((unsigned value, int length));
local void bi_windup OF((deflate_state *s));
local void bi_flush OF((deflate_state *s));
local void copy_block OF((deflate_state *s, charf *buf, unsigned len,
int header));

#ifdef GEN_TREES_H
local void gen_trees_header OF((void));
Expand Down Expand Up @@ -869,11 +867,17 @@ void ZLIB_INTERNAL _tr_stored_block(s, buf, stored_len, last)
int last; /* one if this is the last block for a file */
{
send_bits(s, (STORED_BLOCK<<1)+last, 3); /* send block type */
bi_windup(s); /* align on byte boundary */
put_short(s, (ush)stored_len);
put_short(s, (ush)~stored_len);
zmemcpy(s->pending_buf + s->pending, buf, stored_len);
s->pending += stored_len;
#ifdef ZLIB_DEBUG
s->compressed_len = (s->compressed_len + 3 + 7) & (ulg)~7L;
s->compressed_len += (stored_len + 4) << 3;
s->bits_sent += 2*16;
s->bits_sent += stored_len<<3;
#endif
copy_block(s, buf, (unsigned)stored_len, 1); /* with header */
}

/* ===========================================================================
Expand Down Expand Up @@ -1197,30 +1201,3 @@ local void bi_windup(s)
s->bits_sent = (s->bits_sent+7) & ~7;
#endif
}

/* ===========================================================================
* Copy a stored block, storing first the length and its
* one's complement if requested.
*/
local void copy_block(s, buf, len, header)
deflate_state *s;
charf *buf; /* the input data */
unsigned len; /* its length */
int header; /* true if block header must be written */
{
bi_windup(s); /* align on byte boundary */

if (header) {
put_short(s, (ush)len);
put_short(s, (ush)~len);
#ifdef ZLIB_DEBUG
s->bits_sent += 2*16;
#endif
}
#ifdef ZLIB_DEBUG
s->bits_sent += (ulg)len<<3;
#endif
while (len--) {
put_byte(s, *buf++);
}
}

0 comments on commit a456d89

Please sign in to comment.