Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'make check' return failure if test fails #225

Closed
wants to merge 1 commit into from

Conversation

stilor
Copy link

@stilor stilor commented Feb 11, 2017

Currently, make returns success because the last command (rm -f) succeeds.

Signed-off-by: Alexey Neyman stilor@att.net

Currently, make returns success because the last command (rm -f) succeeds.

Signed-off-by: Alexey Neyman <stilor@att.net>
stilor added a commit to stilor/crosstool-ng that referenced this pull request Feb 11, 2017
Upstream: madler/zlib#225

Signed-off-by: Alexey Neyman <stilor@att.net>
@madler
Copy link
Owner

madler commented Feb 12, 2017

Thanks. Will update accordingly.

@madler madler closed this Feb 12, 2017
@tbeu
Copy link
Contributor

tbeu commented Feb 12, 2017

Thanks. This likely fixes #192.

@stilor
Copy link
Author

stilor commented Feb 12, 2017

@tbeu: not yet, the maintainer closed this without picking up the changes. I guess @madler is going to implement this in some other way?

@tbeu
Copy link
Contributor

tbeu commented Feb 14, 2017

Right, the changes are not yet pushed.

@stilor stilor deleted the fix-make-check-to-fail branch May 25, 2017 06:00
hzhuang1 pushed a commit to Linaro/warpdrive-zlib that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants