Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CC logic in configure #607

Closed
wants to merge 1 commit into from
Closed

Fix CC logic in configure #607

wants to merge 1 commit into from

Commits on Mar 28, 2022

  1. Fix CC logic in configure

    In e9a52aa,
    the logic was changed to try check harder for GCC, but it dropped
    the default setting of cc=${CC}. It was throwing away any pre-set CC value as
    a result.
    
    The rest of the script then cascades down a bad path because it's convinced
    it's not GCC or a GCC-like compiler.
    
    This led to e.g. misdetection of inability to build shared libs
    for say, multilib cases (w/ CC being one thing from the environment being used
    for one test (e.g. x86_64-unknown-linux-gnu-gcc -m32 and then 'cc' used for
    shared libs (but missing "-m32"!)). Obviously just one example of how
    the old logic could break.
    
    This restores the old default of 'CC' if nothing overrides it later
    in configure.
    
    Bug: https://bugs.gentoo.org/836308
    Signed-off-by: Sam James <sam@gentoo.org>
    thesamesam committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    80d0863 View commit details
    Browse the repository at this point in the history