Skip to content

Commit

Permalink
DT/RF: Ensure cat features are recorded per group
Browse files Browse the repository at this point in the history
JIRA: MADLIB-1254

If tree_train/forest_train is run with grouping enabled and if one of
the groups has a categorical feature with just single level, then the
categorical feature is eliminated for that group. If other groups retain
that feature, then we end up with incorrect "bins" data structure built
as part of DT.

This commit fixes this issue by recording the categorical features
present in each group separately.

Closes apache#295
  • Loading branch information
iyerr3 committed Jul 18, 2018
1 parent 4349e77 commit bf5fa81
Show file tree
Hide file tree
Showing 3 changed files with 155 additions and 89 deletions.

0 comments on commit bf5fa81

Please sign in to comment.