Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate Aura:If in Cell #47

Closed
madmax983 opened this issue Mar 8, 2018 · 1 comment
Closed

Eliminate Aura:If in Cell #47

madmax983 opened this issue Mar 8, 2018 · 1 comment
Assignees
@madmax983
Labels
enhancement wontfix

Comments

@madmax983
Copy link
Owner

Eliminate the aura:if used in the cell component. Over a large set of data this will have a big performance impact.
@madmax983 madmax983 self-assigned this Mar 8, 2018
@madmax983 madmax983 mentioned this issue Mar 12, 2018
Closed
madmax983 added a commit that referenced this issue Mar 18, 2018
@madmax983
#47 A ton more javascript logic to get rid of the two aura:if refs in…
0d6acb5 
… cell. Onblur logic for editing works, but enter does not.
@madmax983
Copy link
Owner Author

So there is work in the no-cell-aura-if that is my general first stab at doing this. Not totally happy with the code, and really not happy with the amount of effort required to get rid of the two aura:ifs in cell.

I am also not seeing a super big performance boost. Wish there was a better way of benchmarking. I'll iterate on this a bit more, but don't think I will be merging anything anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madmax983 madmax983

Labels
enhancement wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madmax983