unsubscribe on component destroy

madmax983 · Aug 30, 2018 · 33ce2cb · 33ce2cb
1 parent 389c24c
commit 33ce2cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/force-app/main/default/aura/Redux/Redux.cmp b/force-app/main/default/aura/Redux/Redux.cmp
@@ -1,5 +1,6 @@
 <aura:component description="Redux">
     <ltng:require scripts="{!$Resource.redux}"/>
+    <aura:handler name="destroy" value="{!this}" action="{!c.handleUnsubscribe}"/>
     <aura:attribute name="name" type="string" default="redux" />
     <aura:method name="createStore" action="{!c.createStore}">
         <aura:attribute name="name" type="string" />

diff --git a/force-app/main/default/aura/Redux/ReduxController.js b/force-app/main/default/aura/Redux/ReduxController.js
@@ -163,7 +163,7 @@
 
             handleChanges();
 
-            window.reduxStore[reduxName].subscribe(handleChanges);
+            component.unsubscribe = window.reduxStore[reduxName].subscribe(handleChanges);
             target.dispatch = window.reduxStore[reduxName].dispatch;
         } else {
             if(window.subscriberQueue && window.subscriberQueue[reduxName]) {
@@ -179,6 +179,11 @@
                 }];
             }
         }
+    },
+    handleUnsubscribe: function(component) {
+      if (component.unsubscribe) {
+        component.unsubscribe();
+      }
     }
 
 })