Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add Python 3.10 to tests #510

Merged
merged 2 commits into from Aug 25, 2022
Merged

ci: Add Python 3.10 to tests #510

merged 2 commits into from Aug 25, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 24, 2022 •
edited 

* Add Python 3.10 to GitHub Action workflows and the testing matrix.
* Add Python 3.10 to PyPI metadata classifiers.

@matthewfeickert
ci: Add Python 3.10 to tests
926afc9 
* Add CPython 3.10 to GitHub Action workflows and the testing matrix.
@matthewfeickert
docs: Add Python 3.10 to PyPI metadata classifiers
5f4c6a5
@matthewfeickert matthewfeickert marked this pull request as ready for review August 24, 2022 19:47
@matthewfeickert
Copy link
Member Author

@alexander-held this is ready for review.

alexander-held
alexander-held approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks ok to me. We currently only get 23% coverage from the tests but I spontaneously don't see anything that I would expect to break given that the dependencies work.

@alexander-held alexander-held merged commit 03cd67b into madminer-tool:master Aug 25, 2022
@matthewfeickert matthewfeickert deleted the ci/add-python-310 branch August 25, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-held alexander-held alexander-held approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewfeickert @alexander-held