Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14 #15

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fixes #14 #15

merged 1 commit into from
Dec 11, 2020

Conversation

NinoSkopac
Copy link
Contributor

Replaces the old style call_user_func_array() style with a new one, which makes it work in PHP8

@NinoSkopac
Fixes madnest#14
8828281 
Replaces the old style `call_user_func_array()` style with a new one, which makes it work in PHP8
@theimerj theimerj merged commit d3a8b9c into madnest:master Dec 11, 2020
@theimerj
Copy link
Collaborator

Thank you!

@NinoSkopac
Copy link
Contributor Author

Also, I think should be tagged as v1.1.1

@theimerj
Copy link
Collaborator

theimerj commented Dec 13, 2020 •
edited
Loading

I will tag a new version soon. There seems to be some problem with Mockery, which adds duplicate null types. It is kind of difficult to debug. Any ideas?

Screen Shot 2020-12-13 at 18 46 55

I added this line Mockery::setLoader(new Mockery\Loader\RequireLoader(sys_get_temp_dir())); to TestCase.php, so I could see the actual mock file being generated after running the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NinoSkopac @theimerj