Call reset method in next tick (#264)

- call reset method in next tick
- format the tests
- use fakeAsync in the second beforeEach block
- remove unnecessary AfterViewInit from the wizard component tests
- organizing the imports inside the tests
- fixing a spelling error
Co-authored-by: earshinov <earshinov@gmail.com>

src/lib/components/wizard-completion-step.component.spec.ts

@@ -1,9 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, TestBed} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {MovingDirection} from '../util/moving-direction.enum';
-import {WizardComponent} from './wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, TestBed, fakeAsync, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { MovingDirection } from '../util/moving-direction.enum';
+import { WizardComponent } from './wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -53,13 +53,17 @@ describe('WizardCompletionStepComponent', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create', () => {
     expect(wizardTest).toBeTruthy();

src/lib/components/wizard-navigation-bar.component.spec.ts

@@ -43,13 +43,17 @@ describe('WizardNavigationBarComponent', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create', () => {
     expect(wizardTest).toBeTruthy();

src/lib/components/wizard-step.component.spec.ts

@@ -1,9 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, TestBed} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {MovingDirection} from '../util/moving-direction.enum';
-import {WizardComponent} from './wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, TestBed, fakeAsync, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { MovingDirection } from '../util/moving-direction.enum';
+import { WizardComponent } from './wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -53,13 +53,17 @@ describe('WizardStepComponent', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create', () => {
     expect(wizardTest).toBeTruthy();

src/lib/components/wizard.component.spec.ts

@@ -1,9 +1,9 @@
-import { AfterViewInit, ChangeDetectorRef, Component, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { ArchwizardModule } from '../archwizard.module';
-import { WizardComponent } from './wizard.component';
 import { WizardStep } from '../util/wizard-step.interface';
+import { WizardComponent } from './wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -23,7 +23,7 @@ import { WizardStep } from '../util/wizard-step.interface';
     </aw-wizard>
   `
 })
-class WizardTestComponent implements AfterViewInit {
+class WizardTestComponent {
   public navigateForward = 'deny';
   public navigateBackward = 'deny';
 
@@ -36,14 +36,6 @@ class WizardTestComponent implements AfterViewInit {
 
   @ViewChild(WizardComponent)
   public wizard: WizardComponent;
-
-  constructor(private _changeDetectionRef: ChangeDetectorRef) {
-  }
-
-  public ngAfterViewInit(): void {
-    // Force another change detection in order to fix an occuring ExpressionChangedAfterItHasBeenCheckedError
-    this._changeDetectionRef.detectChanges();
-  }
 }
 
 describe('WizardComponent', () => {
@@ -59,13 +51,17 @@ describe('WizardComponent', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create', () => {
     expect(wizardTest).toBeTruthy();

src/lib/components/wizard.component.ts

@@ -171,8 +171,8 @@ export class WizardComponent implements AfterContentInit {
     // initialize the model
     this.updateWizardSteps(this.wizardStepsQueryList.toArray());
 
-    // finally reset the whole wizard componennt
-    this.reset();
+    // finally reset the whole wizard component
+    setTimeout(() => this.reset());
   }
 
   /**

src/lib/directives/completed-step.directive.spec.ts

@@ -1,7 +1,7 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
-import {ArchwizardModule} from '../archwizard.module';
-import {WizardComponent} from '../components/wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { ArchwizardModule } from '../archwizard.module';
+import { WizardComponent } from '../components/wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -31,11 +31,16 @@ describe('WizardStep', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
+
     wizard = wizardTestFixture.componentInstance.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should mark initially completed steps', () => {
     expect(wizard.getStepAtIndex(0).completed).toBe(false);

src/lib/directives/enable-back-links.directive.spec.ts

@@ -1,9 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {MovingDirection} from '../util/moving-direction.enum';
-import {WizardComponent} from '../components/wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { MovingDirection } from '../util/moving-direction.enum';
+import { WizardComponent } from '../components/wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -56,13 +56,17 @@ describe('EnableBackLinksDirective', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create', () => {
     expect(wizardTest).toBeTruthy();

src/lib/directives/go-to-step.directive.spec.ts

@@ -1,9 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, fakeAsync, TestBed} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {GoToStepDirective} from './go-to-step.directive';
-import {WizardComponent} from '../components/wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { GoToStepDirective } from './go-to-step.directive';
+import { WizardComponent } from '../components/wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -68,13 +68,17 @@ describe('GoToStepDirective', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create an instance', () => {
     expect(wizardTestFixture.debugElement.query(By.css('aw-wizard-navigation-bar'))

src/lib/directives/next-step.directive.spec.ts

@@ -1,10 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {NavigationMode} from '../navigation/navigation-mode.interface';
-import {NextStepDirective} from './next-step.directive';
-import {WizardComponent} from '../components/wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { WizardComponent } from '../components/wizard.component';
+import { NextStepDirective } from './next-step.directive';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -53,13 +52,17 @@ describe('NextStepDirective', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create an instance', () => {
     expect(wizardTestFixture.debugElement.query(

src/lib/directives/optional-step.directive.spec.ts

@@ -1,9 +1,9 @@
-import {OptionalStepDirective} from './optional-step.directive';
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, TestBed} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {WizardComponent} from '../components/wizard.component';
+import { OptionalStepDirective } from './optional-step.directive';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, TestBed, fakeAsync, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { WizardComponent } from '../components/wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -40,13 +40,17 @@ describe('OptionalStepDirective', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create an instance', () => {
     expect(wizardTestFixture.debugElement.query(By.directive(OptionalStepDirective))).toBeTruthy();

src/lib/directives/previous-step.directive.spec.ts

@@ -1,9 +1,9 @@
-import {Component, ViewChild} from '@angular/core';
-import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {ArchwizardModule} from '../archwizard.module';
-import {PreviousStepDirective} from './previous-step.directive';
-import {WizardComponent} from '../components/wizard.component';
+import { Component, ViewChild } from '@angular/core';
+import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
+import { ArchwizardModule } from '../archwizard.module';
+import { PreviousStepDirective } from './previous-step.directive';
+import { WizardComponent } from '../components/wizard.component';
 
 @Component({
   selector: 'aw-test-wizard',
@@ -52,13 +52,17 @@ describe('PreviousStepDirective', () => {
     }).compileComponents();
   }));
 
-  beforeEach(() => {
+  beforeEach(fakeAsync(() => {
     wizardTestFixture = TestBed.createComponent(WizardTestComponent);
     wizardTestFixture.detectChanges();
 
     wizardTest = wizardTestFixture.componentInstance;
     wizard = wizardTest.wizard;
-  });
+
+    // wait a tick to ensure that the initialization has been completed
+    tick();
+    wizardTestFixture.detectChanges();
+  }));
 
   it('should create an instance', () => {
     expect(wizardTestFixture.debugElement.query(