Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable step indicators + HTML code rework #147

Merged
merged 3 commits into from Sep 26, 2018

Conversation

earshinov
Copy link
Contributor

PR #143 rebased onto develop branch.

@earshinov earshinov changed the title Develop clickable step indicators Clickable step indicators + HTML code rework Sep 26, 2018
@madoar madoar merged commit 98095fd into madoar:develop Sep 26, 2018
@earshinov earshinov deleted the develop-clickable-step-indicators branch September 28, 2018 11:03
@madoar
Copy link
Owner

madoar commented Oct 13, 2018

@earshinov the layout changes to the vertical layout lead to some visual errors:

  • the step titles are not vertically centered
  • the circle of the step indicators are distorted on the y-axis (vertically)

An example:
grafik

@earshinov
Copy link
Contributor Author

@madoar , Ouch! I will try to get to it next week.

@madoar
Copy link
Owner

madoar commented Oct 13, 2018

Thanks :)
After this bug has been fixed I'm planning to publish a new release (i.e. version 4.0.0) to npm.

@earshinov
Copy link
Contributor Author

@madoar , I created new #159. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants