Add Disabled input for step, and prevent from moving into disabled step #177
Conversation
Add custom css input for navigation Add custom CSS class for each step in navigation Add Enums: - NavBar Directions - NavBar Layout - NavBar Location - Navigation Mode Formatted the code
| optional: isOptional(step), | ||
| navigable: isNavigable(step) | ||
| }"> | ||
| [ngClass]="getStepClass(step)"> |
There was a problem hiding this comment.
This way I can add custom class
There was a problem hiding this comment.
I like the idea of moving the json object creation to a typescript method.
But I don't understand, why a custom class needs to be added via customNavBarClass.
Starting with version 4.0.0 of angular-archwizard, the intended way to create a custom navbar indicator is via the awWizardStepSymbol directive.
For an example see https://github.com/madoar/angular-archwizard-demo/blob/develop/src/app/custom-step-symbol-template/custom-step-symbol-template.component.html.
| @@ -86,16 +84,13 @@ describe('WizardComponent', () => { | |||
| expect(wizardTestFixture.debugElement.query(By.css('aw-wizard > :first-child')).name).toBe('aw-wizard-navigation-bar'); | |||
| expect(wizardTestFixture.debugElement.query(By.css('aw-wizard > :last-child')).name).toBe('div'); | |||
|
|
|||
| expect(navBar.classes).toEqual({ | |||
There was a problem hiding this comment.
It no longer need to have all classes with false and true, but only the classes that needed
|
|
||
| /** | ||
| * The layout of the navigation bar inside the wizard. | ||
| * The layout can be either small, large-filled, large-empty or large-symbols | ||
| * The layout can be either small, large-filled, large-empty, large-symbols, large-filled-symbols or large-empty-symbols |
There was a problem hiding this comment.
Add types of layout that didn’t written in the documentation
| /** | ||
| * Navigation class | ||
| */ | ||
| private _navigationClass: any = {}; |
There was a problem hiding this comment.
Improve performance instead of calculating each time update when change accord
There was a problem hiding this comment.
Again, I like the idea to create the json object in a typescript method instead of inline in the template.
The creation of the navigationClass json object seems to be a bit complex to me.
Do we really require the ability to add a custom class here?
The intended way to change the visual design of the navigation bar is to override the navigation bar style like in https://github.com/madoar/angular-archwizard-demo/blob/develop/src/app/custom-css/custom-css.component.css.
|
About the Enums: Therefore I think it's better to continue using strings for the inputs. |
|
Just as a short note:
I believe it's better to split the different changes in individual PRs. |
|
The pull request #178 contains everything that this pull request contain and more |
Add custom css input for navigation
Add custom CSS class for each step in navigation
Add Enums:
Formatted the code