Rename BaseNavigationMode.checkReset to ensureCanReset #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return value instead of `boolean`. An error is indicated by an exception.
madoar
approved these changes
Apr 16, 2019
| return false; | ||
| } | ||
| protected ensureCanReset(): void { | ||
| super.ensureCanReset(); | ||
|
|
||
| // the default step is a completion step and the wizard contains more than one step | ||
| const defaultCompletionStep = this.wizardState.getStepAtIndex(this.wizardState.defaultStepIndex) instanceof WizardCompletionStep; | ||
| if (defaultCompletionStep && this.wizardState.wizardSteps.length !== 1) { | ||
| throw new Error(`The default step index ${this.wizardState.defaultStepIndex} references a completion step`); |
There was a problem hiding this comment.
I think we will need to rethink whether starting inside a completion step is really a reason for an Error.
If we look at #170 it may be a good idea to allow for a wizard to initialize inside a completion step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkResettoensureCanResetvoidreturn value instead ofbooleanAn error is indicated by an exception.
See discussion: #166 (comment)