Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: IVY true and false #282

Merged
merged 3 commits into from Apr 6, 2020
Merged

Tests: IVY true and false #282

merged 3 commits into from Apr 6, 2020

Conversation

hugoj-goncalves
Copy link
Contributor

@hugoj-goncalves hugoj-goncalves commented Apr 2, 2020

Fixes #278

Tests passed locally.
Demo worked just fine also, with and without IVY

@hugoj-goncalves hugoj-goncalves changed the title Ivy false WIP: Ivy false Apr 2, 2020
@hugoj-goncalves hugoj-goncalves changed the title WIP: Ivy false Ivy false Apr 2, 2020
@hugoj-goncalves hugoj-goncalves changed the title Ivy false Tests: IVY true and false Apr 2, 2020
angular.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
src/lib/components/wizard.component.spec.ts Outdated Show resolved Hide resolved
Copy link
Owner

@madoar madoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR against the develop branch

@hugoj-goncalves
Copy link
Contributor Author

Will make the changes in a few hours when I get off my work.

package.json Outdated Show resolved Hide resolved
@hugoj-goncalves
Copy link
Contributor Author

I think that's it. Let me know if you need anything else.

@madoar madoar merged commit 34819c4 into madoar:develop Apr 6, 2020
@madoar
Copy link
Owner

madoar commented Apr 6, 2020

@hugoj-goncalves thank you for fixing this!

I'm currently not sure whether to release a version 6.0.1 containing only this fix, or whether I should wait until #280 has been fixed before releasing version 6.1.0. I'm open for suggestions :)

@hugoj-goncalves
Copy link
Contributor Author

I can't see a reason to wait, as it's broken for people that are not using ivy.
ofc it is working just fine with v5.0.0, but I bet ppl will have to lose some time finding the closed issue first or openning new issues until it gets released.

but it's totally up to you, I can only thank you for this amazing component ;)

@earshinov
Copy link
Contributor

@madoar, Please-please-please release 6.0.1! We've also come across this problem after upgrading to Angular 9 and aw 6.0.0.

@madoar
Copy link
Owner

madoar commented Apr 20, 2020

Ok, I have just released angular-archwizard version 6.0.1!

Please give me feedback whether the new version fixes your issue.

@earshinov
Copy link
Contributor

Yes, the issue is fixed after we upgraded to 6.0.1. Thank you very much for a prompt response!

@sfrinx
Copy link

sfrinx commented Apr 22, 2020

For me not work and I use Ionic with angular 8

@sfrinx
Copy link

sfrinx commented Apr 22, 2020

Work only if I use this "encapsulation: ViewEncapsulation.None" in my component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgraded to Angular 9 and that seems to have broken the css
4 participants