Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rtl support #286

Merged
merged 3 commits into from Apr 26, 2020
Merged

added rtl support #286

merged 3 commits into from Apr 26, 2020

Conversation

KarimTayie
Copy link
Contributor

@KarimTayie KarimTayie commented Apr 17, 2020

added rtl support to the latest version.
this pr should solve this issue #280

Copy link
Owner

@madoar madoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add an example for this to the Demo Repository?
This would help me a lot with testing this change. In addition I think it would also help other people who want to use right-to-left direction :)

Slightly off-topic:
Do you think we should retain the navBarDirection input attribute of the WizardComponent?

src/css/wizard-navigation-bar.scss Show resolved Hide resolved
@KarimTayie
Copy link
Contributor Author

Can you please also add an example for this to the Demo Repository?
This would help me a lot with testing this change. In addition I think it would also help other people who want to use right-to-left direction :)

Slightly off-topic:
Do you think we should retain the navBarDirection input attribute of the WizardComponent?

I have made a pr to add rtl example to the demo repo. madoar/angular-archwizard-demo#69
I am not really sure about retaining the navBarDirection input attribute, I assume we can leave it as it is for now. maybe others are depending on it.

@madoar madoar merged commit 05ee884 into madoar:develop Apr 26, 2020
@madoar
Copy link
Owner

madoar commented Apr 26, 2020

@KarimTayie thank you very much for fixing this Issue!

I will cherry pick this change to the version 5.0.0 branch and release a new version 5.0.1 in addition to version 6.1.0 so that hopefully everyone can use this change :) Most likely I will release the next version either during the next week or on the next weekend.

@KarimTayie
Copy link
Contributor Author

@madoar Thank you for your excellent guidance and amazing effort put on this repo.
just don't forget to note that version 5 uses before pseudo-class instead of after pseudo-class and I am not sure if there are other differences. if you need any help in updating version 5 please don't hesitate to mention me.

@madoar
Copy link
Owner

madoar commented May 3, 2020

just don't forget to note that version 5 uses before pseudo-class instead of after pseudo-class and I am not sure if there are other differences.

Please correct me if I am wrong, but I don't think this is an issue in this case because the changes seem to be independent of the whether the "lines" are drawn in the before or after pseudo-class, right?

madoar added a commit that referenced this pull request May 10, 2020
@KarimTayie
Copy link
Contributor Author

just don't forget to note that version 5 uses before pseudo-class instead of after pseudo-class and I am not sure if there are other differences.

Please correct me if I am wrong, but I don't think this is an issue in this case because the changes seem to be independent of the whether the "lines" are drawn in the before or after pseudo-class, right?

@madoar sorry for the late reply as I was very busy lately.
yes, you are right.
I have tried to update archwizard to v5.0.1 to an angular v8 project and everything LGTM.
great job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants