Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dont lock poetry #17

Closed
jkowalleck opened this issue Sep 27, 2023 · 0 comments · Fixed by #18
Closed

chore: dont lock poetry #17

jkowalleck opened this issue Sep 27, 2023 · 0 comments · Fixed by #18
Labels

Comments

@jkowalleck
Copy link
Collaborator

this is a library, expected to be usable in various environments.
therefore, it is needed to run the lib in various test envs, too.

the poetry lock file is making this hard.
therefore: lets remove the poetry lock file, if possible.

for QA reasons, the ci/tests should run periodically, to check if all dependencies still match
the dev-dependnecies should be pinned to exact versions, to make testing reliable, despite the absence if a lock file.


and for some reasons, the current lock file appears to cause problems on CI:

jkowalleck added a commit that referenced this issue Sep 27, 2023
- fixes [#17](#17)
- poetry lockfile no longer in VCS
- pin dev-dependencies (to the version that was used in lockfile)
-  gitignore more 
- bump poetry version that is used in CI, to fix poetry issues ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant