Runtime crash on iOS 8

[jjshammas]

If I try to run an app on iOS 8 that uses this plugin, I crash immediately with this error:

dyld: Symbol not found: _OBJC_CLASS_$_UIApplicationShortcutIcon

[jordanbyron]

@Kemcake can you confirm this? TBH I didn't test iOS versions < 9

[ptmt]

+1. I'm actually even can't compile with XCode 6. Yeah, this is my fault as a developer to forget about this when deploying to AppStore.

- (void)application:(UIApplication *)application performActionForShortcutItem:(UIApplicationShortcutItem *)shortcutItem completionHandler:(void (^)(BOOL succeeded)) completionHandler {
  [RNQuickActionManager onQuickActionPress:shortcutItem completionHandler:completionHandler];
}

UIApplicationShortcutItem: Expected a type

[jordanbyron]

@ptmt @jjshammas since I assume you both have the iOS 8.x simulator installed, can you try changing the line in your AppDelegate.m file to this:

- (void)application:(UIApplication *)application performActionForShortcutItem:(NSObject *)shortcutItem completionHandler:(void (^)(BOOL succeeded)) completionHandler {
  [RNQuickActionManager onQuickActionPress:shortcutItem completionHandler:completionHandler];
}

I'm curious to see if that works. I'm downloading the simulator now but it's a big file so it may take a while.

[jordanbyron]

@jjshammas @ptmt at this point I'm pretty close to saying, "It just ain't gonna work", but I'm willing to be proven wrong. I spent a little while playing around with the 8.x iOS simulator and I can't get it working without removing nearly all references to UIApplicationShortcut classes.

@Kemcake let us know if there is something magical you did you get it working that we are missing.

[grabbou]

Can't we use compile-time macros? http://stackoverflow.com/a/19790136

More details on various techniques here https://developer.apple.com/library/ios/documentation/DeveloperTools/Conceptual/cross_development/Introduction/Introduction.html

[ptmt]

It would be nice solution if Apple can recompile apps against each SDK. As far as I understand, they don't do it, so we need a dynamic runtime checking. I'm thinking about something like this:

@interface RCTApplicationShortcutItem : NSObject
@end

@implementation RCTApplicationShortcutItem

- (instancetype)init
{
    Class UIApplicationShortcutItem = NSClassFromString(@"UIApplicationShortcutItem");
    if (NSClassFromString(@"UIApplicationShortcutItem")) {
        return [[UIApplicationShortcutItem alloc] init];;
    }
    return self;
}

@end

I hope to find the better and shorter solution, if not, will try to use this approach and test it today.

Too bad that there is at 17% share by iOS8, and it's even more on our target audience.

[ptmt]

So, I wasted a few hours on #13, but it scares me. I would go with Weak Linking (with simple Class checking as you already have in master) or even just would set target = iOS9 (sorry iOS 8 users).

[jordanbyron]

Since we don't have any sane solutions for this issue I am going make the call that for now this project does not support older versions of iOS. If anyone wants to work on this more I'd be happy to review their work and merge it in if it doesn't add a ton of complexity. 🎱