Add combo keyboard shortcuts. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being pressed...
… and keyup functions. Tests pass.
…s in the same combo (like the two 'o' keys in 'you rock')
… a little more descriptive of what it actually is.
…a keyboard combination. This would cause a problem if the first key is also a shortcut. Added this warning to the README. Also updated contribution attribution.
…e ones when the current buffer could result in a combo execution. If not, the clear the buffer.
|
Just doing some clean-up. This will obviously never get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to say:
key('g&i', handler);where the user can press g followed by i to execute the handler.The test is a little crazy because we need to test the time between key presses, but it works alright. I'd be happy to make changes if you think that there are any necessary.