Fix .replaceWith to allow more than 1 node as replacement -- with tests

madrobby · May 24, 2011 · 65a1c1d · 65a1c1d
1 parent 2b6487b
commit 65a1c1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/zepto.js b/src/zepto.js
@@ -174,7 +174,9 @@ var Zepto = (function() {
     },
     replaceWith: function(newContent) {
       return this.each(function() {
-		    this.parentNode.replaceChild($(newContent)[0], this);
+        var par=this.parentNode,next=this.nextSibling;
+        $(this).remove();
+        next ? $(next).before(newContent) : $(par).append(newContent);
       });
     },
 	  wrap: function(newContent) {

diff --git a/test/zepto.html b/test/zepto.html
@@ -535,6 +535,12 @@ <h1>Zepto DOM unit tests</h1>
         t.assertUndefined($('#replace_test').get(0));
         t.assert(document.getElementsByClassName("replace_test_div")[0].nodeType);
         t.assertEqual($('.replacewith h2#replace_test').get(0), document.getElementsByClassName("replace_test")[0]);
+
+        //Multiple elements
+        $('.replacewith .replace_test_div').replaceWith('<div class="inner first">hi</div><div class="inner fourth">hello</div>');
+        t.assertLength(4,$('.replacewith div'));
+        t.assertEqual("inner first", $('.replacewith div')[0].className);
+        t.assertEqual("inner fourth", $('.replacewith div')[1].className);
       },
 
       testWrap: function(t) {