Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outerHeight not supported #1268

Closed
gnadelwartz opened this issue Feb 20, 2017 · 2 comments
Closed

outerHeight not supported #1268

gnadelwartz opened this issue Feb 20, 2017 · 2 comments

Comments

@gnadelwartz
Copy link

Hi,

I successfully mirgated my script to zepto and found one problem: .outerHeight() is not supported.
the migration also point me to the fact that .first() and .not() are faster than jquery :first and :not pseudo selector :-)

for the outerHeight problem I used the workaround from here (solution 2):
http://stackoverflow.com/questions/10787782/full-height-of-a-html-element-div-including-border-padding-and-margin

Performance of zepto is same as with jquery, may be a litte better.

@gnadelwartz
Copy link
Author

gnadelwartz commented Feb 20, 2017

as I mention, the conversion of my userscript to zepto was easy, this is the full diff:
https://greasyfork.org/de/scripts/24244-enstylerjs-develop/diff?v1=176309&v2=175801

@madrobby
Copy link
Owner

madrobby commented Aug 6, 2017

I think this is one of the more esoteric jQuery functions. You could easily support this in a Zepto plugin. Closing this unless there's more interest in adding it as a feature.

@madrobby madrobby closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants