Use an anchor tag for parsing URLs instead of a regex #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!settings.crossDomain) { | ||
| urlAnchor = document.createElement('a') | ||
| urlAnchor.href = settings.url | ||
| settings.crossDomain = window.location.protocol + '//' + window.location.host !== urlAnchor.protocol + '//' + urlAnchor.host |
There was a problem hiding this comment.
I think location could be used directly instead of window.location, but window.location is used in other parts of this file so I went with that.
There was a problem hiding this comment.
I would add parentheses here so that the comparison is more readable.
|
I see what you did there, sir! 🙈 🙊 |
mislav
added a commit
that referenced
this pull request
Dec 11, 2014
Use an anchor tag for parsing URLs instead of a regex
|
Thanks! |
|
Turns out this probably broke IE support. They always add the port to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of problems with the regex being used for parsing the Ajax URL and determining if it is same origin:
.in scheme.https:///google.com).?or#.The regex could be updated to better match the URL parsing spec, but it is much simpler to let the browser do the heavy lifting for us.
This PR creates an anchor tag and sets it's
hrefto the Ajax URL. It then compares theprotocolandhostof this anchor tag with those ofwindow.location./cc @mislav