Remove deprecated load/unload event shorthands
#1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were deprecated in jQuery 1.8 and conflict with Ajax `fn.load()` method. Depending on the order of Zepto modules, `load()` was an entirely different method, so to resolve the conflict we remove the deprecated shorthands for event handling. Fixes loading "event" module after "ajax" and not having Ajax `load()` method overriden.
mislav
force-pushed
the
remove-load-shortcut
branch
from
1c76296
to
5e39c19
Compare
|
Let's add this in 2.x, because it's a backwards-breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were deprecated in jQuery 1.8 and conflict with Ajax
fn.load()method. Depending on the order of Zepto modules,load()was an entirely different method, so to resolve the conflict we remove the deprecated shorthands for event handling.Fixes #1099