Test to show tap and click events #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso fires a click event on the element below it, if the tap event moves the tapped element out of the way.
|
Related: #553 |
ghost
assigned
|
Closing this because we don’t want to add extra features to the Please note that mobile browsers are finally attempting to fix the click vs. tap problem for good, for a discussion on this for mobile Safari please see https://webkit.org/blog/5610/more-responsive-tapping-on-ios/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue '"tap" event bug; triggering click after on anything that is in the coordinate range.'
#511
states in a comment from @madrobby that a test is needed to show what the problem is.
I have created a test to show the following:
Run the test on an Android device/simulator or iOS device/simulator and it will fail. Run it on a desktop browser and it will be fine.
The test requires manual intervention (you have to click the red box) - this is why I have put it into it's own file. The up/down/fire functions that are used by other touch tests do not illustrate this problem.
The reason for the problem is that mobile browser will fire both the tap and click events. The tap gets fired first, with the click fired shortly after.