Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing size method for PCGALowRankMatrix #2

Merged
merged 2 commits into from Jan 28, 2018

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Jan 24, 2018

IterativeSolvers.jl now uses max(size(A)) in least-square solvers to determine the maximum number of iterations. This method is missing for the PCGALowRankMatrix of GeostatInversion.jl

@coveralls
Copy link

coveralls commented Jan 25, 2018

Coverage Status

Coverage increased (+0.09%) to 85.075% when pulling 9ac00e6 on haampie:fix-size-method into d4957ac on madsjulia:master.

@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #2 into master will decrease coverage by 0.5%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   84.98%   84.47%   -0.51%     
==========================================
  Files           8        8              
  Lines         333      335       +2     
==========================================
  Hits          283      283              
- Misses         50       52       +2
Impacted Files Coverage Δ
src/lowrank.jl 84.9% <0%> (-3.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4957ac...9ac00e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants