Fix EdDSA keys / improve YubiKey support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! I will look into it and include it in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues we faced with YubiKeys.
First issue:
ktyandcrvcan either beintortstraccording to the RFC, where the string version should be one of the constants (likeOKPorEd25519). However, this library parses only the int version. This PR adds support for the string constants related to elliptic curves. There are likely more places where string constants are applicable, but the provided fixes are at least enough to get YubiKey working. Example input of such a key:{1: 'OKP', 3: -8, -1: 'Ed25519'}.Second issue: some keys generate broken keys during registration (two errors: map length is wrong, and public key component
xis bytearray instead of bytestring). See this issue for a more in-depth discussion. While this is technically not a fault in this library, this PR adds a workaround that detects and fixes those broken keys. Other webauthn libraries use such workarounds as well.