fix: sourcemap handling #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
I've noticed that I'm getting incorrect source maps from
postcsswith using this plugin. This PR should fix this behavior.The PR itself is a bit messy, becase I've removed all the changes I made in #142 (so its easier to review) and it changes all the snapshots.
The snapshots have changed because I've changed the logic from
string concatenationto "native"postcss nodes. This causes newlines and possibly whitespaces to be different, but the content is the same.I've also added and adapted tests to reflect the changes.
If you want you can check the correctness of the sourcemaps yourself with this tool: https://evanw.github.io/source-map-visualization/ - Just upload the generated file and its sourcemap