Make tests work with Python 3.13 #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attribute `created` of LogRecord is `time.time_ns` since Python 3.13: https://docs.python.org/3.13/library/logging.html#logrecord-attributes
|
Would keeping both decorators make it compatible? |
This will work with Python < 3.13.
|
It seems so, I updated the PR. |
hroncok
approved these changes
Jun 10, 2024
|
Just so you're aware it looks like python-json-logger is currently unmaintained, that said I am working on a maintained fork which includes testing against Python 3.13. |
|
FWIW I don't see this test in your fork. |
The test on the timestamp does still exist, however I've moved to using https://github.com/nhairs/python-json-logger/blob/main/tests/test_formatters.py#L452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute
createdof LogRecord istime.time_nssince Python 3.13: https://docs.python.org/3.13/library/logging.html#logrecord-attributesThis is not a backwards compatible change.