-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sources online #90
Conversation
WalkthroughThe update involves adding "Sources Online" to the list of platforms that provide access to digital scholarly text editions in Switzerland. This new source enhances the collection with its integration of TEI Publisher and IIIF, offering a significant resource for digital humanities research. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
src/lib/data/entries.json
is excluded by:!**/*.json
Files selected for processing (1)
- README.md (1 hunks)
Additional comments: 2
README.md (2)
- 161-161: The addition of "Sources Online" to the Switzerland section enriches the collection with a valuable resource for digital scholarly text editions. This entry is well-placed within the list, maintaining the alphabetical order and thematic consistency of the section.
- 158-164: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [190-190]
Consider using consistent spelling for words like "flavours" and "flavors" throughout the document to maintain consistency, especially if the document targets an international audience. This is a minor issue but can enhance the readability and professionalism of the document.
Pull Request
Add
Sources Online
insrc/lib/data/entries.json
.Short pitch
Closes #89
Checklist
Please ensure that you have completed the following tasks:
npm run prepare
to sort the entries insrc/lib/data/entries.json
alphabetically and to generate theREADME.md
file.npm run format
to format the repository code.npm run awesome-lint
to ensure that theREADME.md
file is formatted correctly.Criteria for accepting a pull request
Contributors, please ensure that:
Maintainers, please ensure that:
Updating your PR
If the maintainers notice anything that needs to be changed, they will ask you to edit your PR before merging it. Please do not open a new PR, just edit the existing one. If you're not sure how to do that, here is a guide on the different ways you can update your PR.
Appendix: running lint tests
To run tests locally using Node.js, you need to install the dependencies first:
Summary by CodeRabbit