-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show_harmo_error
shows success rate <100% when there are no errors
#17
Comments
This feature (specificatlly separte errors from warnings) will be updated in the future. This has multiple implications backstage (the reason is because some warnings in R are conceptually errors, but cast as warnings) |
20/10/2023 - To change before CRAN. Harmo team vote |
Works well. Should all aligned left or the middle columns could be centered |
Layout looks nice overall! |
Hi @twey2 and thank you for your contribution. For the 'case_whe' rule category, this example is generated with the DPE - with errors in DEMO_files_harmo object. In this scenario, we tried to mimic some errors, including typo in the rule category. Let's say the user writes 'direct_maping' or, like here, 'case_whe' instead of 'case_when' For the terminology, good point, I'll make the change right away. |
Great! |
show_harmo_error
shows success rate <100% when there are warnings but no errors, which is confusing. I think it would be better for the success rate to reflect only the errors, and I think the warnings and errors should be split up. But the way the warnings are highlighted in this version are useful!The text was updated successfully, but these errors were encountered: