Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histograms for date variables display invalid ranges #37

Open
twey2 opened this issue Nov 6, 2023 · 2 comments
Open

Histograms for date variables display invalid ranges #37

twey2 opened this issue Nov 6, 2023 · 2 comments
Labels
enhancement New feature or request next version

Comments

@twey2
Copy link

twey2 commented Nov 6, 2023

In visual reports, histograms for date variable display invalid ranges that don't match the Summary statistics or Span date representation. Two examples below. In the first, N3RO shows dates that are too early and too late (and MOBYDIck has dates too early). In the second, MOBYDIck has the same issue.

image

image

@GuiFabre GuiFabre added next version good first issue Good for newcomers bug Something isn't working and removed next version labels Nov 7, 2023
@GuiFabre GuiFabre pinned this issue Nov 8, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 9, 2023

Hello @twey2,

The date graphs have some issues that will be adressed and corrected in the next version. Temporarly, assuming that the first graph (of span) works, it will be maintained, meanwhile the second (histograms) will be replaced by a whisker plot. Even tho this solution is a bit redondant (span is include in both graphs), It'll allow to have 2 functionning graphs, with breaking the code.

This solution is temporary.

image
image

@GuiFabre GuiFabre added next version and removed bug Something isn't working labels Nov 9, 2023
GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Nov 9, 2023
@GuiFabre GuiFabre added to test and removed good first issue Good for newcomers labels Nov 9, 2023
@twey2
Copy link
Author

twey2 commented Nov 9, 2023

The function in the updated package now produces the whisker plot, and it looks accurate to me.

I don't completely understand the issue with having 2 plots, but if required and we can't make a histogram, why not have a whisker plot and a pie chart with % valid/% missing like for some other variable types?

I think the histogram would still be better than the boxplot if we could just change the units to something smaller (weeks or days instead of year) and/or find a way to pick a more logical number of bins to display based.

@GuiFabre GuiFabre unpinned this issue Nov 9, 2023
@GuiFabre GuiFabre added enhancement New feature or request and removed to test labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next version
Projects
None yet
Development

No branches or pull requests

2 participants