Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Avoid confusing changes in color scheme in visual reports #38

Closed
twey2 opened this issue Nov 6, 2023 · 2 comments
Closed
Labels
enhancement New feature or request to test

Comments

@twey2
Copy link

twey2 commented Nov 6, 2023

In visual reports, confusing when color scheme changes from one section to another within the same variable. In the example, one study is in green and the other is in yellow throughout the whole report, except right at the end, both are in yellow in the pie chart. Ideally keep the same color scheme throughout.
image

Edit: I realize this is related to other cases when the color is tied to a value, but then the the rules are applied inconsistently.
image
image

@GuiFabre GuiFabre added bug Something isn't working next version good first issue Good for newcomers and removed bug Something isn't working labels Nov 7, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 8, 2023

for grouped variable
A decision had been made earlier between two possibilities:
When a graphic shows variable A and variable B grouped by another variable C (lets say a study) then :

EITHER the color refers to the group : The grouping variable has n elements, they the graph shows accross variable A and B always the same color for each n. In that scenario, the first study is green, the second is yellow, the third is red then blue. any additional color will be picked from the rest of the palette
(unfortunatelly, sometimes the color chosen in the palette are not realy different from each other. that will be evaluated in the next version)
OR the color refers to graphic elements : The grouping variable is not taken in account, so the color always refer the variable itself. The first graphic element will always be green, then the second yellow, the third is red, and then blue. any additional will be picked from the rest of the palette.

In the first scenario, MOBYDick will always be green across all the graphs, and N3RO always yellow.
In the second scenario, the first graph of each variable will always be green, the second graph yellow, and rest of them red, then blue, then color picked. Meaning that the graph showing (lets say) a wisker plot will be all green, for both studies.

The decision has been made to consider the first scenario.

(when there is no group, there is nothing to be discussed, the variable A will have each category in a different color).

for the pie chart
It was confusing indeed. The color palette was taken from maelstrom, also used for valid values.

Another color palette has been chosen.
FYI, The colors are always the same. The only mandatory one is for 'NA values' it must be the same in the NA values shown in the bar plot. If you think about a better palette, just tell me.

image

@GuiFabre GuiFabre pinned this issue Nov 8, 2023
GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Nov 8, 2023
@twey2
Copy link
Author

twey2 commented Nov 9, 2023

The new palette for the pie chart works well for me.

For the grouped variable, that is fine. I think it was really just the pie chart that was the most confusing.

@GuiFabre GuiFabre added enhancement New feature or request and removed next version labels Nov 9, 2023
@GuiFabre GuiFabre unpinned this issue Nov 9, 2023
@GuiFabre GuiFabre closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to test
Projects
None yet
Development

No branches or pull requests

2 participants