Add providers tab to advanced iap settings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note (to self): this also relies on certain strings I have added to |
MerlijnWajer
force-pushed
the
wip-provider-support
branch
from
cc8d20e
to
4b46ef4
Compare
MerlijnWajer
force-pushed
the
wip-provider-support
branch
from
a4e7046
to
8a9ec12
Compare
MerlijnWajer
changed the title
|
The code reads the dir entries in |
freemangordon
requested changes
Aug 24, 2021
MerlijnWajer
force-pushed
the
wip-provider-support
branch
2 times, most recently
from
82b82b6
to
c8e2f04
Compare
Also read service types and ids from gconf.
It is unnecessarily complex to validate them against a list, since the list needs to be provided up front, and we read them from gconf later, so hacking that in would be quite some work, make the code less clean, and ultimately there's not really a point: we already decide what goes in the combo box, we don't need to validate it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for selecting providers in the advanced internet settings.
I think the service_type should be a list of what we can find in gconf under
/system/osso/connectivity/srv_provider.The service_id I am less sure of, I think we need to figure out where we write those (they could indicate different provider configs, like different openvpn networks, or something).
Currently the values are just hardcoded and in sync with https://github.com/maemo-leste/libicd-provider-dummy/