osso-abook-contact-field: if no telepathy account is availbe to handel tel and sms, try hildon-mime. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tel and sms, try hildon-mime. This allows abook to be more useful with non-telepathy dialers such as sphone-ofono or phosh calls
|
this requires maemo-leste/libhildonmime#5 |
freemangordon
requested changes
Oct 3, 2023
| { | ||
| if (TP_IS_ACCOUNT(account)) | ||
| { | ||
| rv = request_channel(account, OSSO_ABOOK_CONTACT_ACTION_TEL, |
There was a problem hiding this comment.
rv = request_channel(account, OSSO_ABOOK_CONTACT_ACTION_SMS, values->data, &error);
There was a problem hiding this comment.
same "better code" note as above
| @@ -4715,11 +4737,34 @@ osso_abook_contact_action_start_with_callback( | |||
| if (contact_action_mmicode(data, values->data)) | |||
| return TRUE; | |||
|
|
|||
| rv = request_channel(account, OSSO_ABOOK_CONTACT_ACTION_TEL, | |||
| if (TP_IS_ACCOUNT(account)) | |||
There was a problem hiding this comment.
I think a better code would be:
if (TP_IS_ACCOUNT(account))
rv = request_channel(account, OSSO_ABOOK_CONTACT_ACTION_TEL, values->data, &error);
if (!rv)
rv = contact_action_tel_as_uri(parent, values->data);
| contact_action_tel_as_uri(GtkWindow *parent, const char *line_id) | ||
| { | ||
| gchar *uri = g_strconcat("tel://", line_id, NULL); | ||
| HildonURIAction *action = hildon_uri_get_xdg_action(); |
There was a problem hiding this comment.
I am not sure we shall prefer xdg-open here, lets leave libhidonmime decide for us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows abook to be more useful with non-telepathy dialers such as sphone-ofono or phosh calls