Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding String.trim to Ecto Type cast() #89

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Adding String.trim to Ecto Type cast() #89

merged 4 commits into from
Jan 14, 2022

Conversation

h4cc
Copy link
Contributor

@h4cc h4cc commented Jan 14, 2022

Fixing #88

Automatic tests seem to be broken :(

@maennchen
Copy link
Owner

@h4cc I fixed the CI. Thanks for the PR ❤️

@maennchen maennchen linked an issue Jan 14, 2022 that may be closed by this pull request
Ignoring leading/trailing whitespace in Parser.parse #88
Closed
@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited

Coverage Status

Coverage increased (+1.0%) to 99.567% when pulling c922ecc on h4cc:ecto-type-trim into 81bd15a on jshmrtn:master.

@maennchen
Copy link
Owner

@h4cc Could you run mix format?

@maennchen maennchen mentioned this pull request Jan 14, 2022
Closed
@h4cc
Copy link
Contributor Author

h4cc commented Jan 14, 2022

@h4cc Could you run mix format?

Done

@maennchen maennchen merged commit 878757d into maennchen:master Jan 14, 2022
@maennchen
Copy link
Owner

@h4cc Thanks. Released as v1.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignoring leading/trailing whitespace in Parser.parse
3 participants
@h4cc @maennchen @coveralls