Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PRs from forks in build_validation CI #100

Closed
fflaten opened this issue Apr 14, 2024 · 1 comment
Closed

Support PRs from forks in build_validation CI #100

fflaten opened this issue Apr 14, 2024 · 1 comment

Comments

@fflaten
Copy link
Contributor

fflaten commented Apr 14, 2024 •
edited

PRs from forks always get failed CI due to read-only permissions to workflow checks.

Consider moving "Publish Pester test results" step to it's own workflow as described here: https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories
merill added a commit that referenced this issue Apr 16, 2024
@merill
Split build-validation: #100
c95e9cd
merill added a commit that referenced this issue Apr 16, 2024
@merill
Merge pull request #105 from maester365/pr/68
4a8b17f 
Split build-validation: #100
@merill
Copy link
Contributor

merill commented Apr 16, 2024

This has been implemented now. Thanks for the suggestion @fflaten

@merill merill closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merill @fflaten