[MARLIN-615] Add ability to specify sync from date in synchronization job #187
Conversation
|
Majority of changes are just changes in variable names. Only real code change is here: https://github.com/maestrano/maestrano-connector-rails/pull/187/files#diff-f0257db6f246dbf7a243a8b6fe2bdef7R68 plus the specs for this behavior change. |
|
|
||
| it 'passes the correct sync_from dates' do | ||
| organization.synchronized_entities.each do |entity, _| | ||
| expect_any_instance_of(Maestrano::Connector::Rails::SynchronizationJob).to receive(:sync_entity) |
There was a problem hiding this comment.
Really just need to test the sync_from. Tested entity.to_s and organization because their readily available.
The other arguments don't relate to this option and would be a pain to test. Don't think its necessary.
|
Just the Travis CI failing tests |
iseessel
force-pushed
the
improvement/marlin-615-add-ability-to-sync-delta
branch
2 times, most recently
from
3ec9ed8
to
f6ed35c
Compare
|
This will not make it into tonight's release, since we're choosing to move forward with https://github.com/maestrano/marlin-banking-adapter/pull/49 for now |
|
@ouranos Can we push to have this tested and deployed soon? It would require reverting: https://github.com/maestrano/marlin-banking-adapter/pull/49 and changing the parameters on the hourly sync. |
iseessel
force-pushed
the
improvement/marlin-615-add-ability-to-sync-delta
branch
from
f6ed35c
to
ec42d06
Compare
|
@ouranos I rebased and removed my travis commit like you said, but now my travis build is failing. |
|
@ouranos @alexmaestrano Can you review latest changes. |
iseessel
force-pushed
the
improvement/marlin-615-add-ability-to-sync-delta
branch
from
38c8035
to
4045c30
Compare
No description provided.