Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uib-carousel & uib-slide cannot be an element #120

Merged
merged 1 commit into from Jan 10, 2017
Merged

uib-carousel & uib-slide cannot be an element #120

merged 1 commit into from Jan 10, 2017

Conversation

alexnoox
Copy link
Contributor

Regardless what the documentation says (https://angular-ui.github.io/bootstrap/#/carousel)

Use a <uib-carousel> element with <uib-slide> elements inside it.

the code specifically restrict uib-carousel & uib-slide to be an attribute (https://github.com/angular-ui/bootstrap/blob/master/src/carousel/carousel.js#L289).

@ouranos FYI

@alexnoox alexnoox merged commit a269e30 into maestrano:master Jan 10, 2017
MichaelSedov pushed a commit to MichaelSedov/mno-enterprise-angular that referenced this pull request Jan 26, 2017
[MNOE-177] UI: SignUp Page: Error message displayed when email is already registered
@alexnoox alexnoox deleted the fix-carousel branch June 20, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant