[MARLIN-748] add deeplink endpoint to pages controller #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiuzhong
requested review from
iseessel and
cesar-tonnoir
and removed request for
adamaziz15
ouranos
reviewed
May 15, 2019
api/config/routes.rb
Outdated
| @@ -1,6 +1,7 @@ | |||
| MnoEnterprise::Engine.routes.draw do | |||
| # Generic routes | |||
| get '/launch/:id', to: 'pages#launch', constraints: {id: /[\w\-\.:]+/} | |||
| get '/deeplink/:oid/:etype/:eid', to: 'pages#deeplink', constraints: {oid: /[\w\-\.]+/, eid: /[\w\-]+/} | |||
There was a problem hiding this comment.
Same here have a more meaningful name for the variables
ouranos
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on the ticket, mno-enterprise need to expose the deeplink endpoint as below:
get '/deeplink/:oid/:etype/:eid', to: 'pages#deeplink', constraints: {oid: /[\w\-\.]+/, eid: /[\w\-]+/}