Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Added puppet lint fixes #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jfroche
Copy link

@jfroche jfroche commented Feb 29, 2012

Hello,

I have done some puppet lint fixes

@ghost ghost assigned carlossg Mar 1, 2012
@carlossg
Copy link
Member

carlossg commented Mar 1, 2012

thanks for the patch.
Not sure we want to use replace => false for the puppet config file, we want to be able to change values from puppet, and be able to update the sonar version, which may include changes to the config file

@carlossg
Copy link
Member

carlossg commented Mar 1, 2012

wondering a couple more things,

is there any reason not to use

  • class 'sonar' in init.pp
  • sonar::home in plugin.pp and move_to_home.pp?

I'm applying the lint fixes and leave that for a different commit

@brettporter
Copy link
Contributor

Should we close this pull request and open a new one for the other fixes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants