Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with other Chromecast enabled devices #29

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Fix compatibility with other Chromecast enabled devices #29

merged 1 commit into from
Oct 17, 2017

Conversation

andyshinn
Copy link
Contributor

This should supersede #28. It changes two things:

  • Instead of trying to look up the A record (which has a different name than the PTR data), we just use the PTR data to lookup the same name of the SRV record which has the actual hostname we can connect to. This just uses the names as-is so any Google Cast device should be found.
  • I also added the dns-txt package to decode the associated TXT record to get the friendly name and use that if it exists.

Not sure if there is a better way to handle this. But open to suggestions. I was thinking the TXT record could be later expanded to gather all the fields in case they might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants