Replace buffer constructor with buffer-alloc and buffer-from #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.12.1 |
|
@jasnell just wondering, why not |
|
Buffer.from means major bump. Too many dependents would be affected by that |
|
Time to switch to using Buffer.from now? it's 2020 now |
8 tasks
shellscape
pushed a commit
that referenced
this pull request
Jun 2, 2020
I see builtin buffer utils were not used because of old node support. Though they are dropped now. And there is no need in these dependencies. #83 (comment) Though I hope this change will not recover this problem. #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.