Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace buffer constructor with buffer-alloc and buffer-from #83

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Mar 21, 2018

No description provided.

@mafintosh mafintosh merged commit 9fc626a into mafintosh:master Mar 21, 2018
@mafintosh
Copy link
Owner

1.12.1

@caub
Copy link

caub commented Apr 1, 2018

@jasnell just wondering, why not Buffer.from ? do you still need node 0.12 and less support (which are EOL anyway)

@mafintosh
Copy link
Owner

Buffer.from means major bump. Too many dependents would be affected by that

@jimmywarting
Copy link

Time to switch to using Buffer.from now? it's 2020 now

shellscape pushed a commit that referenced this pull request Jun 2, 2020
I see builtin buffer utils were not used because of old node support.
Though they are dropped now. And there is no need in these dependencies.

#83 (comment)

Though I hope this change will not recover this problem.

#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants