Skip to content

Commit

Permalink
check for .. also in encodingLength
Browse files Browse the repository at this point in the history
  • Loading branch information
mafintosh committed May 25, 2021
1 parent bb04450 commit bd84615
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ name.decode = function (buf, offset) {
name.decode.bytes = 0

name.encodingLength = function (n) {
if (n === '.') return 1
if (n === '.' || n === '..') return 1
return Buffer.byteLength(n.replace(/^\.|\.$/gm, '')) + 2
}

Expand Down Expand Up @@ -1442,7 +1442,9 @@ exports.CHECKING_DISABLED = 1 << 4
exports.DNSSEC_OK = 1 << 15

exports.encode = function (result, buf, offset) {
if (!buf) buf = Buffer.allocUnsafe(exports.encodingLength(result))
const allocing = !buf

if (allocing) buf = Buffer.allocUnsafe(exports.encodingLength(result))
if (!offset) offset = 0

const oldOffset = offset
Expand All @@ -1462,6 +1464,11 @@ exports.encode = function (result, buf, offset) {

exports.encode.bytes = offset - oldOffset

// just a quick sanity check
if (allocing && exports.encode.bytes !== buf.length) {
return buf.slice(0, exports.encode.bytes)
}

return buf
}

Expand Down

0 comments on commit bd84615

Please sign in to comment.