Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change class option to take strings and document it #4

Merged
merged 1 commit into from Jan 12, 2018

Conversation

silverwind
Copy link
Collaborator

This changes to class option to take strings instead of integers, so 1 becomes 'IN', 3 becomes 'CH' and so on. Also documented the class option.

Two questions:

  1. Should I reduce the documentation on the option? Given that most people will probably never need that option, we could remove it from the example. On the other hand, this is a low level library so it might just be okay to keep it.
  2. This is a breaking change for a undocumented option. Should we still do a major version bump to be safe?

Fixes: #3

@silverwind
Copy link
Collaborator Author

I just read about the unicast-response bit that multicast dns encodes in the class bytes. I'm thinking that we could encode in a separate property.

@mafintosh
Copy link
Owner

👍 and 👍 to using a different prop for unicast

@mafintosh
Copy link
Owner

@silverwind should we merge this?

@silverwind
Copy link
Collaborator Author

No, it's not done yet, I'll check it out later. We should probably do a patch release before we land this, because this one will be major bump.

This changes to class option to take strings instead of integers, so 1
becomes 'IN', 3 becomes 'CH' and so on. Also documented the class
option.
@silverwind
Copy link
Collaborator Author

Rebased, I will track the unicast-response thing in a separate issue.

@silverwind silverwind merged commit 3b76b23 into master Jan 12, 2018
@silverwind silverwind deleted the string-class branch January 12, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class option
2 participants