Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated Buffer API #3

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Feb 24, 2018

Use Buffer.from when it's available instead of 'new Bufer(arr)'

Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

This is one of the three changes needed to keep npm i working under NODE_PENDING_DEPRECATION=1 without warnings. The other two are mafintosh/duplexify#17 and isaacs/node-tar#175.

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Mar 2, 2018

Tracking: nodejs/node#19079

@mafintosh mafintosh merged commit c703a5d into mafintosh:master Mar 2, 2018
@mafintosh
Copy link
Owner

👍

@mafintosh
Copy link
Owner

1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants