breaking, fix, perf: ESM, drop buffer, modernize #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes this library, migrates to ESM, drops buffer and updates dependencies.
The git diff shows some crazy stuff, but in practice all that really changed is all the functions were moved into a class,
Buffer.isBufferwas replaced withArrayBuffer.isViewand a few other tiny tweaks, dropped util.inherits and updated docs accordingly.Doing this because webtorrent is updating it's dependencies to deprecate buffer, one of which is bencode, which also runs on the browser, even tho this package doesn't, and since the new bencode is ESM only this also needs to be ESM