Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Should we use the standard code-style linter from feross? #214

Closed
watson opened this issue Jun 29, 2015 · 3 comments
Closed

RFC: Should we use the standard code-style linter from feross? #214

watson opened this issue Jun 29, 2015 · 3 comments

Comments

@watson
Copy link
Collaborator

watson commented Jun 29, 2015

Hi guys

I would like to convert mongojs to support standard. I know this can quickly turn into a bikeshedding debate so let me just open by saying I personally don't care about what coding style we use - as long as we use one and preferably back it up by a linter.

The reason why I propose this is because:

  • It will help contributors who create pull requests to make better pull requests
  • It will catch my own stupid errors like misspelling of variable names, forgetting to require a module, forgetting to remove an old variable that's no longer used etc.

If you guys say go, I'll do the refactor :)

@saintedlama
Copy link
Collaborator

👍

1 similar comment
@mafintosh
Copy link
Collaborator

👍

@mafintosh
Copy link
Collaborator

fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants