added optional 'network interface' address option #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great! |
mafintosh
added a commit
that referenced
this pull request
Jan 12, 2015
added optional 'network interface' address option
|
Added some docs for this in the README. Released in 1.2.0. Thanks for the patch |
|
Thanks a lot, that was fast! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to receive some queries and found out that explicitly specifying a multicast interface in socket.addMembership solved this. I'm not sure exactly why (addMembership should add memebership to all valid interfaces by default), but it looks like this is not a rare issue: http://stackoverflow.com/questions/14130560/nodejs-udp-multicast-how-to
Therefore, I believe adding an option to specify the interface argument for the addMembership might be useful. I'm not very familiar with UDP, however - perhaps it would be even better to make it possible to specify multiple interfaces, etc.