Use prebuild-install as dependency

[piranna]

Since prebuild-install package is a stripped-down version of prebuild just to download and install the images, use it as dependency instead of having two codes for the download step that would became divergent in the future and lead to problems by having two different versions.

[lgeiger]

I didn't know about prebuild-install and instead tried to reduce the package size of prebuild in #144

That said I really like the idea of having two separate modules. Though I think we should make them exclusive.
One for handling the downloading, the other only handling the developer part. I think this would be clearer for users instead of having two tools doing the same thing.

In fact prebuild and prebuild-install have already diverged a bit since the latest release.

Hence it may make sense to maintain them in the same repo despite shipping two different npm packages. Tools like Lerna help with managing such monorepos.

I'm happy to make PRs for this.

[piranna]

That said I really like the idea of having two separate modules. Though I think we should make them exclusive.

I would agree on that, I only asked about having it as dependency just to don't break backwards compatibility up to some degree.

Hence it may make sense to maintain them in the same repo despite shipping two different npm packages.

I think it makes sense to have them as two independent projects as they are currently being done, the only common place is the "protocol", that's mostly just targz files published as github releases, no more...

[lgeiger]

I think it makes sense to have them as two independent projects as they are currently being done, the only common place is the "protocol", that's mostly just targz files published as github releases, no more...

I thought they share a lot of code in util.js but that's not the case. The easiest thing it probably to keep them separate.

[lgeiger]

I see two possibilities for reducing the effort of maintaining prebuild and prebuild-install:

1. Remove all install and download related code from prebuild and advice users to use prebuild-install as a dependency and prebuild only for generating the prebuilts. This will significantly (approx. 10MB) reduce the download size of the prebuilt module.

2. Keep the current functionality and use prebuilt-install to handle the downloading.

I'm in favor of the first option since it doesn't introduce duplicated functionality, is easier to maintain and promotes a cleaner workflow for users.

What do you think?

[piranna]

What do you think?

+1000 to first option (prebuild and prebuild-install as independent but inter-related modules), specially for the cleaner wofkflow argument.

[ralphtheninja]

Remove all install and download related code from prebuild and advice users to use prebuild-install as a dependency and prebuild only for generating the prebuilts. This will significantly (approx. 10MB) reduce the download size of the prebuilt module.

Agreed.