Remove node-gyp dependency #144
Conversation
| @@ -163,7 +170,6 @@ prebuild [options] | |||
| --compile -c (compile your project using node-gyp) | |||
| --no-compile (skip compile fallback when downloading) | |||
| --libc (use provided libc rather than system default) | |||
| --backend (specify build backend, default is 'node-gyp') | |||
There was a problem hiding this comment.
this option will have to stay, for ninja support
There was a problem hiding this comment.
I guess if we want to keep ninja we need to include it as a dependency again since it isn't bundled with npm.
But ninja requires node-gyp so we can't remove it and won't gain any improvement in package size.
There was a problem hiding this comment.
But it would work if the user has node-ninja installed or explicitly included as a dependency of the native module.
I'll add support for it after #145 is merged so I can verify it works.
| @@ -1,5 +1,5 @@ | |||
| var fs = require('fs') | |||
| var async = require('async') | |||
| var waterfall = require('async-waterfall') | |||
lgeiger
force-pushed
the
npm-rebuild
branch
2 times, most recently
from
2fe6d65
to
96ca343
Compare
|
The node-ninja build fails on Node 0.12. I don't think this is a problem of |
| @@ -0,0 +1,3 @@ | |||
| node_modules | |||
| npm-debug.log | |||
| test/ | |||
| "prebuild:ninja": "../../bin.js --prebuild 7.2.1 --backend node-ninja" | ||
| }, | ||
| "dependencies": { | ||
| "node-ninja": "^1.0.2" | ||
| } |
|
I discovered |
|
@lgeiger I'm cleaning up a bit. Since |
This PR brings down the size of
node_modulesfrom 10.9MB to 1.3MB.Fixes #143